Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiwi/builder/live: Cleanup leftover dracut config file and log correct application id #2623

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

Conan-Kudo
Copy link
Member

This pull request contains two small fixes for building live ISOs:

  • A commit to clean up a leftover dracut config file that caused Fedora live media to become non-installable
  • A commit to correctly log the application id whenever a custom one is set

@Conan-Kudo Conan-Kudo marked this pull request as ready for review August 24, 2024 11:16
@Conan-Kudo
Copy link
Member Author

FYI: @tdawson

The existence of this file breaks installers on live media that
sync the full filesystem to disk and are not aware of this configuration
before generating the target system initramfs.
Since it is now possible to set a custom application ID, we want
to see this when it is being used for the image.
@Conan-Kudo
Copy link
Member Author

I've verified with Fedora KDE image builds that this fixes live images so that they are properly installable.

Copy link
Collaborator

@schaefi schaefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Conan-Kudo Conan-Kudo merged commit 11ce3a5 into main Aug 25, 2024
12 checks passed
@Conan-Kudo Conan-Kudo deleted the various-live-fixes branch August 25, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants